Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporterqueue] Implement blocking queue #11951

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[exporterqueue] Implement blocking queue #11951

wants to merge 6 commits into from
+193 −6

Conversation

sfc-gh-sili
Copy link
Contributor

@sfc-gh-sili sfc-gh-sili commented Dec 18, 2024 •
edited
Loading

Description

This PR

  1. Implements blocking memory queue. The queue blocks until the incoming request is successgfully sent out.
  2. Uses blocking queue + queue batcher in place of batch_sender if the feature gate UsePullingBasedExporterQueueBatcher is on.

Link to tracking issue

#8122
#10368

Testing

Documentation

@sfc-gh-sili sfc-gh-sili requested review from bogdandrutu, dmitryax and a team as code owners December 18, 2024 08:39
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.14085% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.66%. Comparing base (7993ef0) to head (b9b0714).

Files with missing lines Patch % Lines
exporter/exporterqueue/blocking_queue.go 82.50% 6 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11951      +/-   ##
==========================================
- Coverage   91.67%   91.66%   -0.01%     
==========================================
  Files         455      456       +1     
  Lines       24038    24103      +65     
==========================================
+ Hits        22037    22095      +58     
- Misses       1629     1635       +6     
- Partials      372      373       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax
Copy link
Member

@sfc-gh-sili please rebase and look at the failing CI

@sfc-gh-sili sfc-gh-sili force-pushed the sili-batching branch 2 times, most recently from 7ea3462 to 0448db0 Compare December 20, 2024 02:19
@sfc-gh-sili sfc-gh-sili force-pushed the sili-batching branch 2 times, most recently from 3028f40 to 946ba78 Compare January 4, 2025 23:03
dmitryax
dmitryax reviewed Jan 6, 2025
View reviewed changes
exporter/exporterhelper/internal/base_exporter.go
usePullingBasedExporterQueueBatcher.IsEnabled() && be.BatcherCfg.Enabled && !be.queueCfg.Enabled {
if usePullingBasedExporterQueueBatcher.IsEnabled() && be.BatcherCfg.Enabled && !be.queueCfg.Enabled {
be.queueFactory = exporterqueue.NewBlockingMemoryQueue[internal.Request]()
be.queueCfg.QueueSize = 20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to set it to 20?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Dmitrii.
The blocking queue is introduced as a hidden logical abstraction to handle the case when batch is enabled and queue is not enabled - it means a component that blocks until the incoming request is successfully sent out, so logically the queue size is infinite. I'd think setting this number to MaxInt would make sense but that broke a bunch of tests, and 20 is just some random number I picked as a work around.

Let me experiment with some alternative solutions to "infinite queue" and get back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax left review comments

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-sili @dmitryax